Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PoS downloader #3717

Merged
merged 40 commits into from
Mar 22, 2022
Merged

Refactor PoS downloader #3717

merged 40 commits into from
Mar 22, 2022

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Mar 16, 2022 •
edited
Loading

Main changes:

  1. There's a list of unfinished Beacon requests (RequestList in turbo/engineapi/request_list.go), whose status could be New or DataWasMissing (meaning sync is necessary)
  2. PoS downloading happens in parallel to beacon request processing in (hd *HeaderDownload) StartPoSDownloader.
  3. We can handle failures to download a PoS block (timeouts).

yperbasis added 23 commits March 6, 2022 16:49
@yperbasis
Remove blockHeight arg from FeedHeaderPoW
9bf9292
@yperbasis
Revert "Remove blockHeight arg from FeedHeaderPoW"
00b7d8c 
This reverts commit 9bf9292.
@yperbasis
Move PayloadMessage & ForkChoiceMessage to package engineapi
eb29b45
@yperbasis
RequestList instead of newPayloadCh & forkChoiceCh
a8e3ac3
@yperbasis
Introduce request status
d08b2a1
@yperbasis
Merge branch 'devel' into kiln_stuff_7
0226499
@yperbasis
Send reply only when request status is New
0de3a71
@yperbasis
Move BeaconRequestList to HeaderDownload
e0d4b71
@yperbasis
Merge branch 'devel' into kiln_stuff_7
856eec3
@yperbasis
Don't SetFetching when PoS (Fetching means handling newBlockHashes)
19a7209
@yperbasis
Merge Syncing & Synced into DataWasMissing
e9112cb
@yperbasis
Merge branch 'devel' into kiln_stuff_7
d16c2fa
@yperbasis
Introduce SyncStatus
d4ecc41
@yperbasis
onlyNew arg in WaitForRequest
114a894
@yperbasis
Merge branch 'devel' into kiln_stuff_7
f88a0a0
@yperbasis
Move waitingForBeaconChain into RequestList
15d0c7b
@yperbasis
Interrupt instead of skipCycleHack
baeac92
@yperbasis
Introduce timeout for PoS headers
4e0d921
@yperbasis
Merge branch 'devel' into kiln_stuff_7
6da02df
@yperbasis
Split downloadMissingPoSHeaders
afce943
@yperbasis
Merge branch 'devel' into kiln_stuff_7
c3d3bdc
@yperbasis
Move StartPoSDownloader into HeaderDownload
f707ff6
@yperbasis
Merge branch 'devel' into kiln_stuff_7
a5443fa
@yperbasis yperbasis changed the title [WIP] Refactor PoS downloader Refactor PoS downloader Mar 21, 2022
@yperbasis yperbasis marked this pull request as ready for review March 21, 2022 09:47
@yperbasis yperbasis merged commit 74a7d7c into devel Mar 22, 2022
@yperbasis yperbasis deleted the kiln_stuff_7 branch March 22, 2022 16:49
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giulio2002 Giulio2002 Giulio2002 approved these changes

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

@AlexeyAkhunov AlexeyAkhunov Awaiting requested review from AlexeyAkhunov

@enriavil1 enriavil1 Awaiting requested review from enriavil1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @Giulio2002