Fix Reverse PoS downloader #4051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
reviewed
May 3, 2022
| if len(segment) == 0 { | ||
| return nil | ||
| func (hd *HeaderDownload) ProcessSegmentPOS(segment ChainSegment, tx kv.Getter, peerId [64]byte) ([]PenaltyItem, error) { | ||
| // segment of one header are usually remainder of gossip, but the peer can still be valid. |
There was a problem hiding this comment.
Can you give an example when it happens? I'm a bit sceptical that we need this special check.
yperbasis
reviewed
May 3, 2022
| return err | ||
| } | ||
| // We prevent pos reverse downloading from happening concurrently with an interrupted sync. | ||
| if s.BlockNumber > executionProgress { |
There was a problem hiding this comment.
Hmm. Not sure about this. In the PoW case we don't wait for execution to finish but rather download new headers first, right?
There was a problem hiding this comment.
it is less code changes, i dont think it makes too much of a difference.
There was a problem hiding this comment.
we would have to pass the headerdownload to all other stages, for now i would reduce this PR only to this change, if you are okay with it
yperbasis
requested changes
May 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.