Don't default to mainnet if NetworkID != 1 #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested review from
somnathb1,
AlexeyAkhunov,
AskAlexSharov,
racytech and
mh0lt
AlexeyAkhunov
approved these changes
Feb 8, 2024
AskAlexSharov
requested changes
Feb 9, 2024
There was a problem hiding this comment.
- please keep
HistoryV3.WriteOnce()beforeWriteGenesis(e3will read it and write genesis a bit different way) - maybe devnet downloading mainnet snapshots #9191 - is also related to this issue
AskAlexSharov
approved these changes
Feb 10, 2024
yperbasis
added a commit
that referenced
this pull request
Feb 29, 2024
After PR #9408 `cfg.Genesis` may be `nil`. Fixes the following issue in Hive tests: ``` runtime error: invalid memory address or nil pointer dereference" stack="[main.go:29 panic.go:914 panic.go:261 signal_unix.go:861 stageloop.go:540 backend.go:773 node.go:124 main.go:65 make_app.go:52 command.go:279 app.go:337 app.go:311 main.go:34 proc.go:267 asm_amd64.s:1650] ```
mriccobene
pushed a commit
to mriccobene/erigon
that referenced
this pull request
Mar 13, 2024
After PR erigontech#9408 `cfg.Genesis` may be `nil`. Fixes the following issue in Hive tests: ``` runtime error: invalid memory address or nil pointer dereference" stack="[main.go:29 panic.go:914 panic.go:261 signal_unix.go:861 stageloop.go:540 backend.go:773 node.go:124 main.go:65 make_app.go:52 command.go:279 app.go:337 app.go:311 main.go:34 proc.go:267 asm_amd64.s:1650] ```
fridrik01
added a commit
to berachain/beacon-kit
that referenced
this pull request
Nov 28, 2024
However, its still not solved as erigon does not respect the --networkid which causes beacond to fail since its expecting chainid 80087. It seems this issue was fixed in erigontech/erigon#9408 but even with pulling a recent docker image its still not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios (e.g. Hive) genesis is initially populated by
erigon initand afterwards erigon is started with somenetworkidflag, typically != 1. In that case it's incorrect to use default (mainnet) genesis instead of reading genesis from the DB.This PR fixes Issue #9191 and also some Hive tests that were incorrectly returning
SYNCINGbecause they were trying to download mainnet snapshots.