Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export RpcDaemon settings #5

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Export RpcDaemon settings #5

merged 3 commits into from
Apr 19, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Apr 15, 2024

This PR improves the configuration support for Silkworm bindings by

  • expanding the general configuration settings with logVerbosity and numIOContexts
  • exporting RpcDaemon-specific configuration settings

Associated PRs:

@canepat
export RpcDaemon settings
44cd2dc 
expand Silkworm library settings
@canepat canepat added the enhancement New feature or request label Apr 15, 2024
@battlmonstr battlmonstr removed their request for review April 16, 2024 06:57
@canepat
Use enum for log level
6b75ee5 
Improve incompatible MDBX error
Add translation for missing options
@canepat canepat marked this pull request as ready for review April 17, 2024 16:30
@canepat canepat merged commit 1fa3163 into master Apr 19, 2024
@canepat canepat deleted the export_rpcdaemon_settings branch April 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacekGlen JacekGlen JacekGlen approved these changes

@Sixtysixter Sixtysixter Awaiting requested review from Sixtysixter

@lupin012 lupin012 Awaiting requested review from lupin012

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canepat @JacekGlen