Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code_address member to evmc_message #288

Merged
merged 7 commits into from
Sep 6, 2021
Merged

Add code_address member to evmc_message #288

merged 7 commits into from
Sep 6, 2021

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Jul 13, 2021

See #286 for the original discussion.

Related PRs: ethereum/evmc#611 and ethereum/evmone#360.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #288 (40c8cd7) into master (b9d01ca) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   84.67%   84.63%   -0.04%     
==========================================
  Files         112      112              
  Lines        9192     9169      -23     
==========================================
- Hits         7783     7760      -23     
  Misses       1409     1409              
Impacted Files Coverage Δ
core/silkworm/execution/evm.hpp 80.00% <ø> (ø)
core/silkworm/execution/evm.cpp 97.80% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d01ca...40c8cd7. Read the comment docs.

@yperbasis yperbasis marked this pull request as ready for review September 5, 2021 11:39
@yperbasis yperbasis requested a review from vorot93 September 5, 2021 11:43
Copy link
Contributor

@Giulio2002 Giulio2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yperbasis yperbasis merged commit b37cd9e into master Sep 6, 2021
@yperbasis yperbasis deleted the code_address branch September 7, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants