Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scopedSlotTextContextFix to stencil config #1

Conversation

rwaskiewicz
Copy link
Contributor

add scopedSlotTextContentFix to Stencil config to enable the changes
made in
ionic-team/stencil@9fc7657,
which was included in the v2.8.1 release of Stencil

Results of applying this patch and running npm start:

Screen Shot 2021-10-22 at 2 25 18 PM

We added doc for this as a part of the release, but the release of Stencil core and the doc site aren't tightly coupled as far as messaging goes - if there's a better way we can raise visibility to how we document features/fixes that are included in releases, I'd love to hear it!

add `scopedSlotTextContentFix` to Stencil config to enable the changes
made in
ionic-team/stencil@9fc7657,
which was included in the v2.8.1 release of Stencil
Copy link
Owner

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eriklharper eriklharper merged commit 56e653b into eriklharper:master Oct 22, 2021
@eriklharper
Copy link
Owner

@rwaskiewicz Thanks Ryan! This is awesome to see this fixed! :)

@rwaskiewicz rwaskiewicz deleted the rwaskiewcz/add-scopedSlotTextContentFix branch October 22, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants