Fix phpstan

erikn69 · Jun 21, 2024 · 1ec6982 · 1ec6982
1 parent 41977f3
commit 1ec6982
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -11,9 +11,10 @@ parameters:
         - database/migrations/add_teams_fields.php.stub
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
-    checkMissingIterableValueType: false
 
     ignoreErrors:
+        -
+			identifier: missingType.iterableValue
         - '#Unsafe usage of new static#'
         # wildcard permissions:
         - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Model::getWildcardClass#'

diff --git a/src/Traits/HasRoles.php b/src/Traits/HasRoles.php
@@ -233,12 +233,14 @@ public function hasRole($roles, ?string $guard = null): bool
 
             return $this->roles
                 ->when($guard, fn ($q) => $q->where('guard_name', $guard))
-                ->contains(function ($role) use ($roles) {
-                    if ($role->name instanceof \BackedEnum) {
-                        return $role->name->value == $roles;
+                ->pluck('name')
+                ->contains(function ($name) use ($roles) {
+                    /** @var string|\BackedEnum $name */
+                    if ($name instanceof \BackedEnum) {
+                        return $name->value == $roles;
                     }
 
-                    return $role->name == $roles;
+                    return $name == $roles;
                 });
         }