overlay_vars in a profile is not used

[benoitc]

I have a default overl_vars file setup and want to use a different one for prod. But the default on e is always used. Could we replace the hex overlay_vars in profile?

have the following config (edited):

{relx, [
  {release, {'someapp', "0.1.0"}, [someapp]},

  {dev_mode, true},
  {include_erts, false},
  {extended_start_script, true},

  {overlay_vars, "config/vars.config"},
  {overlay, [

...
  ]}
]}.

...
{profiles, [

  {prod, [
    {erl_opts, [
      debug_info,
      {parse_transform, lager_transform},
      {parse_transform, mochicow},
      {d, 'HUT_LAGER'}
    ]},

    {deps, [{lager, "3.0.2"}]},

    {release, [lager, someapp]},

    {relx, [
      {dev_mode, false},
      {include_erts, true},
      {extended_start_script, true},
      {overlay_vars, "config/prod.config"}
    ]}

  ]},

}.

and run rebar3 as prod release.

[benoitc]

So as I read the code the merge in relx for a profile is done here:
https://github.com/erlang/rebar3/blob/master/src/rebar_state.erl#L279

and then you merge the relx config:
https://github.com/erlang/rebar3/blob/master/src/rebar_opts.erl#L118-L119

                  (relx, NewValue, OldValue) ->
                       rebar_utils:tup_umerge(OldValue, NewValue);

When I read the code in rebar_utils I see that the first arg is NewList:

tup_umerge(NewList, OldList) ->
    tup_umerge_(tup_sort(NewList), tup_sort(OldList)).

https://github.com/erlang/rebar3/blob/master/src/rebar_utils.erl#L285-L286

So the code in rebar_opts shouldn't be rebar_utils:tup_umerge(NewValue , OldValue); ?

[dilongl]

+1

[ctrldrift]

+1

[ferd]

This may have been fixed in #1606