Version 3.3.3: rebar3 eunit doesn't work anymore

[walter-weinmann]

In the following project https://github.com/walter-weinmann/b_trees the command rebar3 eunit doesn't run any eunit tests. The previous version of rebar3 was ok.

D:\SoftDevelopment\Projects\b_trees_idea\b_trees>rebar3 eunit
===> Verifying dependencies...
===> Compiling b_trees
===> Performing EUnit tests...
======================== EUnit ========================
file "b_trees.app"
  application 'b_trees'
    module 'b_trees'
    module 'test_generator'
    [done in 0.141 s]
  [done in 0.266 s]
module 'performance_SUITE'
  There were no tests to run.

[ferd]

Interesting, there has been no change to the Eunit provider since 3.3.2.

[ferd]

I can however confirm the regression in behavior.

[ferd]

74d290b9c2be6352813c71ad6036a24ddacfae79 is the first bad commit
commit 74d290b9c2be6352813c71ad6036a24ddacfae79
Author: Roberto Aloi <[email protected]>
Date:   Tue Dec 6 11:31:28 2016 +0100

    Restrict regexp to match on files starting with '._'

:040000 040000 51c93b4dee8cde72b3ce561fdb9d2c8c8edb5077 862866dfb7cfcf2dee8ff9d205cc21baddeae70d M      src

after bisecting, this PR: #1403 appears to have broken EUnit for this application.

@robertoaloi Any obvious fix you'd like to bring to it before I just revert the commit?

[ferd]

Oh I get it. The . in a [] group can be literal, but not in parens; this means that any test file that starts with any single character followed by an underscore will fail. Bad regex reading on our part, planning a fix.

[robertoaloi]

Argh! Yes, you're right. There should be a test case for this one. Reverting would have helped b_trees but it would have broken compilation for our apps, since the regexp in 3.3.2 was differently broken. So, thanks for the fix @ferd!