Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors in writing the package cache #2045

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

filmor
Copy link
Contributor

@filmor filmor commented Apr 4, 2019

For some odd reason, from time to time I get (persistent) eaccess errors in tab2file. I still have to investigate, where these come from, but I think the error should be non-fatal.

@ferd
Copy link
Collaborator

ferd commented Apr 4, 2019

This seems reasonable. I have concerns that on the first build, this just causes other errors down the road rather than failing early.

I'd say that the warning is a very good addition. I'm not sure that aborting after it is not the best decision though. How does it behave when you use it and encounter these errors?

@filmor
Copy link
Contributor Author

filmor commented Apr 4, 2019

It's a really odd issue and I will have to recompile ets.erl with a bit of debug information to find out what is happening. I see that it has a fake eaccess that it produces whenever the initial deletion doesn't (seem to) go through here https://github.com/erlang/otp/blob/master/lib/stdlib/src/ets.erl#L822. Maybe it's a latency issue or something of that sort, my ~ is on a Windows share (nothing I can do about that ... :/)

@ferd
Copy link
Collaborator

ferd commented Apr 4, 2019

Sounds good. Will merge. I figure it will work alright to keep functionality when an index is already there, and otherwise the warning will be good to figure out another failure.

@ferd ferd merged commit 67ca662 into erlang:master Apr 4, 2019
@filmor filmor deleted the non-fatal-package-idx-write branch April 5, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants