Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support profile_string overlay var in releases #2155

Merged
merged 7 commits into from
Oct 4, 2019
Merged

Support profile_string overlay var in releases #2155

merged 7 commits into from
Oct 4, 2019

Conversation

g-andrade
Copy link
Contributor

@g-andrade g-andrade commented Aug 31, 2019 •
edited
Loading

As proposed and refined in issue 1254.

@g-andrade g-andrade mentioned this pull request Aug 31, 2019
Closed
ferd
ferd requested changes Sep 1, 2019
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change about the internals of rebar_dir before we expand its API, the rest is good.

@ferd
Copy link
Collaborator

ferd commented Sep 1, 2019

Works for me. Will wait for @tsloughter to give it a look as well though.

@g-andrade
Copy link
Contributor Author

(Discretely bumping this PR out of fear it might slip into oblivion.)

@tsloughter
Copy link
Collaborator

There might be some other overlay vars we should be added, but this is a good start :)

@ferd ferd merged commit 8cdf023 into erlang:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsloughter tsloughter tsloughter approved these changes

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-andrade @ferd @tsloughter