-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uses erlang-certifi #789
uses erlang-certifi #789
Conversation
What's the difference in certificates? I notice it adds more certificates. |
It contains all trusted certificate in https://hg.mozilla.org/mozilla-central/raw-file/tip/security/nss/lib/ckfw/builtins/certdata.txt I am not sure how the rebar one have been built though. |
It's not as easy as including all of mozillas trusted certificates. There are different classifications of certificates and they are trusted for different reasons. A certificate can be for email signing, code signing, only trusted as an intermediate certificate but not as root, etc. Do ceritfi document how they generate their list? |
@ericmj all scripts are available in the certifi organisation: The advantage of using certifi is to rely on the community effect. Indeed certifi is used by Also using a common library would allows to reuse the same validated certificate bundle between different clients. Which is good for the ecosystem imo. |
also by default it only include trusted certificates: https://github.com/certifi/extract-nss-root-certs/blob/master/convert_mozilla_certdata.go#L61-L63 |
Okay, looks like they use good defaults https://github.com/certifi/extract-nss-root-certs/blob/master/convert_mozilla_certdata.go#L268-L270. I can't reach https://certifi.io/. When or how often does certifi update the list from Mozilla and when will the hex package be updated? |
for the https this is a known issue I just bumped them. Python and Go package have been updated 4 days ago. I will make sure that the erlang repo is updated automatically as well . |
Being updated 4 days ago doesn't say much. It seems the last update before that was 4 months ago, that's a pretty a long time. Do they have a policy or something like that explains their process? |
@ericmj well as far as I know it's updated as soon as possible after a mozilla update. I opened a ticket to fix the policy about that ^^. Anyway It will be much faster imo if we are many to watch than having to do it in our corner. |
Oh, wait, one more thing needs to change. rebar.config needs:
|
Otherwise the certs.pem won't be included in the escript. |
Manually merged so I could add that little change to rebar.config. Thanks! |
Erlang certifi is a port of certifi. The CA bundle is derived from Mozilla's canonical set. It provides the same features as rebar_cacerts.
erlang-certifi will be updated as soon as the CA bundle from mozilla is updated.