Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webhook test to not call testbot fixture directly #1276

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Fix webhook test to not call testbot fixture directly #1276

merged 1 commit into from
Dec 27, 2018

Conversation

andrewthetechie
Copy link
Contributor

pytest-dev/pytest#3950

Fixes #1275

In pytest 4.0, calling a figure directly is now no longer ok so they introduced a breaking change.

@ghost ghost added the in progress label Dec 27, 2018
@sijis
Copy link
Contributor

sijis commented Dec 27, 2018

Thanks

@sijis sijis merged commit 840e828 into errbotio:master Dec 27, 2018
@ghost ghost removed the in progress label Dec 27, 2018
@andrewthetechie andrewthetechie deleted the att/fix-testing branch December 27, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewthetechie @sijis