[Fix] globalThis should be writable

es-shims · May 7, 2022 · 8759985 · 8759985
1 parent 53afc39
commit 8759985
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/shim.js b/shim.js
@@ -7,12 +7,12 @@ module.exports = function shimGlobal() {
 	var polyfill = getPolyfill();
 	if (define.supportsDescriptors) {
 		var descriptor = Object.getOwnPropertyDescriptor(polyfill, 'globalThis');
-		if (!descriptor || (descriptor.configurable && (descriptor.enumerable || descriptor.writable || globalThis !== polyfill))) { // eslint-disable-line max-len
+		if (!descriptor || (descriptor.configurable && (descriptor.enumerable || !descriptor.writable || globalThis !== polyfill))) { // eslint-disable-line max-len
 			Object.defineProperty(polyfill, 'globalThis', {
 				configurable: true,
 				enumerable: false,
 				value: polyfill,
-				writable: false
+				writable: true
 			});
 		}
 	} else if (typeof globalThis !== 'object' || globalThis !== polyfill) {

diff --git a/test/shimmed.js b/test/shimmed.js
@@ -19,7 +19,7 @@ test('shimmed', function (t) {
 
 	t.test('writability', { skip: !defineProperties.supportsDescriptors }, function (wt) {
 		var desc = Object.getOwnPropertyDescriptor(globalThis, 'globalThis');
-		wt.equal(desc.writable, false, 'globalThis.globalThis is not writable');
+		wt.equal(desc.writable, true, 'globalThis.globalThis is writable');
 		wt.end();
 	});