Fix CustomMessage not passing the correct parameters #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invocation of `.call` passes the property as first value, but the first value of .call is the `this`. Updates the test to verify both key and value are correctly passed
|
@corrspt Thank you for taking the time 👍 ! |
|
Glad I could help 👍 Keep up the great work with this addon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to create a new validation with a custom message that didn't work as I expected. I was not receiving the key, I dug into the source code and the invocation to
callwas passing thekeyasthis.This PR fixes this and also fixes the test. The test passed because it was essentially checking if the message was correct, but it was invoking the message with
callthe same way as the code. So both the test and code had that small bug.Hope it helps.