Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added password validations #8

Merged
merged 31 commits into from
Jun 16, 2015
Merged

Added password validations #8

merged 31 commits into from
Jun 16, 2015

Conversation

sethbrasile
Copy link
Contributor

No description provided.

@esbanarango
Copy link
Owner

@sethbrasile Thank you for this PR.

Three things.

  1. Rebase master.
  2. I think it worth to have the Length validator as a single validator. So could you use the one already on master when defying the password example.
  3. Tests are now cleaner, could you add some for the new validators you added.

esbanarango and others added 20 commits June 16, 2015 08:03
@esbanarango
v
35b8f52
@sethbrasile
Added messages
aafb06f
@sethbrasile
Added 6 new validations good for use with passwords
a830c4e 
Added mustContainCapital, mustContainLower, mustContainNumber,
mustContainSpecial, minLength, and maxLength
@sethbrasile
Added new validators to readme
299226f
@sethbrasile
Changed acceptable chars and example
d85edcf
@sethbrasile
Fixed messages after rebase
4ba5604
@sethbrasile
Fixed .fmt for tests
3fbb0ec
@sethbrasile
Added password property to model and a couple existing tests
f3f378b
@sethbrasile
Added all other validations to password in model
468f239
@sethbrasile
Added base test
e061c37
@sethbrasile
Added capital character test
daec28a
@sethbrasile
Added lower case character test
3ae0655
@sethbrasile
Added special character test
a0cbfd2
@sethbrasile
Added number test
70f37f7
@sethbrasile
Added a comment
8600950
@sethbrasile
fixing conflicts after rebase for origin
6c4e76a
@sethbrasile
Fixed readme to match length validation
2c22656
@sethbrasile
Fixed typo
d67a74c
@sethbrasile
Fixed another typo
7f5b60b
@sethbrasile
Added note about password validations
b18dcec
@esbanarango
Copy link
Owner

Merging this! Thank you @sethbrasile

esbanarango added a commit that referenced this pull request Jun 16, 2015
@esbanarango
Merge pull request #8 from sethbrasile/master
058ec1e 
Added password validations
@esbanarango esbanarango merged commit 058ec1e into esbanarango:master Jun 16, 2015
@sethbrasile
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethbrasile @esbanarango