Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bswap for 1-byte types #137

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Correct bswap for 1-byte types #137

merged 5 commits into from
Jan 8, 2025

Conversation

eschnett
Copy link
Owner

@eschnett eschnett commented Jan 8, 2025

No description provided.

@eschnett eschnett changed the title Test bswap for 1-byte types Correct bswap for 1-byte types Jan 8, 2025
Copy link
Contributor

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes the TiffImages MWE from #122 (comment).

Thanks for looking into this!

@eschnett eschnett merged commit 2196b14 into master Jan 8, 2025
14 checks passed
@eschnett eschnett deleted the eschnett/bswap branch January 8, 2025 21:25
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (53c9476) to head (1e61e85).
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   88.86%   88.88%   +0.01%     
==========================================
  Files           5        5              
  Lines         566      567       +1     
==========================================
+ Hits          503      504       +1     
  Misses         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maleadt added a commit to JuliaCI/PkgEval.jl that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants