fix: leumi.ts multiple account

[Nic3Guy]

This PR commit a fix to Leumi scraper multiple account support.

The fix: When switching account using the xpath there was a missing /

Relevant issue:

This can clause the "Leumi" part of issue #820

More details on the fix:

For Leumi multi account the issue is due to missing / (backslash)
in lines 183-184
see here: https://github.com/eshaham/israeli-bank-scrapers/blob/cbbf9b7bb9915f51eee680042af0bcc19ad8c8ac/src/scrapers/leumi.ts#L183C3-L183C108

after the xpath there should be 3 backslashes
you can see the example from the Puppeteer documents:

// Same as ::-p-text("My text").
await page.locator('text/My text').click();
// Same as ::-p-xpath(//h2).
await page.locator('xpath///h2').click();
// Same as ::-p-aria(My label).
await page.locator('aria/My label').click();
await page.locator('pierce/div').click();

[baruchiro]

@dimdimi4 @idryzhov Can you please test this?

Please let us know if you have multiple accounts or not.

[michlus]

@dimdimi4 @idryzhov Can you please test this?

Please let us know if you have multiple accounts or not.

I do have multiple accounts at Leumi.
but I don’t know how to test this fix, other than by running Caspion.
so once it’s released (within Caspion), I can validate that it fixes the issue

[idryzhov]

Unfortunately I don't have multiple accounts so can't test this.

[baruchiro]

Unfortunately I don't have multiple accounts so can't test this.

@idryzhov at least test it is not breaking the current one-account flow...

[michlus]

If you confirm this, then once it’s released within Caspion I will confirm whether or not it fixes the multiple account issue (since I do have multiple Leumi accounts). (An alternative is that you instruct me how to test)

…

________________________________ From: Baruch Odem (Rothkoff) ***@***.***> Sent: Monday, November 18, 2024 9:52 AM To: eshaham/israeli-bank-scrapers ***@***.***> Cc: michlus ***@***.***>; Comment ***@***.***> Subject: Re: [eshaham/israeli-bank-scrapers] fix: leumi.ts multiple account (PR #886) Unfortunately I don't have multiple accounts so can't test this. @idryzhov<https://github.com/idryzhov> at least test it is not breaking the current one-account flow... — Reply to this email directly, view it on GitHub<#886 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2NYV2GA6ABMY42LSDAOE632BGMDTAVCNFSM6AAAAABR5B33S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBSGE4DSNRWGY>. You are receiving this because you commented.Message ID: ***@***.***>

[baruchiro]

I tested it with @Nic3Guy and it works

[github-actions]

🎉 This PR is included in version 5.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀