fix(beinleumi): account with no balance (inactive)

[whatuserever]

In Beinleumi, inactive accounts expectedly do no have a balance. See the comparison below between an active and inactive accounts.

This PR fixes #892 by making the balance optional for Beinleumi

Active

Inactive

Test

Ran the scraper and printed scrapeResult.accounts

Before

Error: failed to find element matching selector ".main_balance"

After

[
  {
    accountNumber: '1',
    txns: [ [Object], [Object], [Object], [Object], [Object] ],
    balance: 12345.67
  },
  { accountNumber: '2', txns: [], balance: undefined }
]

[whatuserever]

@baruchiro could you please review 🙏

[baruchiro]

I don't know your JS Scraping experience, but do you think once you have a reference to the balanceElement, get its innerText (instead of using eval again on the same selector)?

[whatuserever]

I have no experience at all with either JS or scraping 🙃

I looked at the Puppeteer docs now, and it looks like we can do balanceElement.evaluate. I tested this and it works.

This is still another evaluation, though. But I guess it's slightly more efficient as it shouldn't be searching for the element in the entire page? Not sure tbh.

[baruchiro]

You see, it is not so important, and I don't think efficiency is critical here.

But it is less confusing, and the code is more straightforward—find an element, and if it exists, take its innerText.

[baruchiro]

@whatuserever Can I register you as a tester for Beinleumi? #830

[github-actions]

🎉 This PR is included in version 5.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[whatuserever]

Sure