Gbfs bixi montreal (changes for #311) #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2018 14:58
Relates to eskerda#311
relates to eskerda#311
This was referenced Mar 24, 2018
Closed
|
Looks good 👍 Congrats on your first contribution! |
|
Thks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the git tutorial ! :) Not creating a branch was kind of a brain fart. I will close the other PR and try to fix my master branch with the guidance you provided, probably by just hard resetting the head to the same commit I branched gbfs-bixi-montreal. Maybe I could have just branched to my secind commit and PR that too, it is indeed possible to get to the same point via multiple ways !
Thks again, I won't hesitate to contribute more in the future ! 🔧