Rename components as components instead of the old services #4451
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/listeners #4451 +/- ##
=====================================================
- Coverage 85.41% 85.38% -0.03%
=====================================================
Files 553 553
Lines 33948 33947 -1
=====================================================
- Hits 28996 28986 -10
- Misses 4952 4961 +9 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
components/rename_from_services
branch
from
abd9d2f to
7cad52c
Compare
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 7cad52c small_tests_27 / small_tests / 7cad52c small_tests_26 / small_tests / 7cad52c small_tests_27_arm64 / small_tests / 7cad52c ldap_mnesia_26 / ldap_mnesia / 7cad52c ldap_mnesia_27 / ldap_mnesia / 7cad52c dynamic_domains_mysql_redis_27 / mysql_redis / 7cad52c dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 7cad52c internal_mnesia_27 / internal_mnesia / 7cad52c dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 7cad52c dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 7cad52c pgsql_cets_27 / pgsql_cets / 7cad52c accounts_SUITE:registration_watchers:admin_notify{error,
{{assertion_failed,assert_many,false,
[#Fun<accounts_SUITE.6.113095676>,#Fun<accounts_SUITE.6.113095676>],
[{xmlel,<<"message">>,
[{<<"from">>,<<"localhost">>},
{<<"to">>,<<"admin@localhost">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"[2025-01-02 07:08:30] The account alice@localhost was registered from IP address 127.0.0.1 on node mongooseim@localhost using mod_register.">>}]}]}],
" <message from='localhost' to='admin@localhost' type='chat'><body>[2025-01-02 07:08:30] The account alice@localhost was registered from IP address 127.0.0.1 on node mongooseim@localhost using mod_register.</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}mysql_redis_27 / mysql_redis / 7cad52c pgsql_mnesia_27 / pgsql_mnesia / 7cad52c pgsql_mnesia_26 / pgsql_mnesia / 7cad52c cockroachdb_cets_27 / cockroachdb_cets / 7cad52c mssql_mnesia_27 / odbc_mssql_mnesia / 7cad52c pgsql_cets_27 / pgsql_cets / 7cad52c |
Services in the context of MongooseIM means something else.
NelsonVides
force-pushed
the
components/rename_from_services
branch
from
7cad52c to
00a4c4b
Compare
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 00a4c4b small_tests_26 / small_tests / 00a4c4b small_tests_27 / small_tests / 00a4c4b small_tests_27_arm64 / small_tests / 00a4c4b ldap_mnesia_26 / ldap_mnesia / 00a4c4b dynamic_domains_mysql_redis_27 / mysql_redis / 00a4c4b dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 00a4c4b ldap_mnesia_27 / ldap_mnesia / 00a4c4b dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 00a4c4b internal_mnesia_27 / internal_mnesia / 00a4c4b dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 00a4c4b pgsql_cets_27 / pgsql_cets / 00a4c4b mysql_redis_27 / mysql_redis / 00a4c4b tcp_listener_SUITE:s2s_inet_sockname_returns_error{error,
{{badrpc,
{'EXIT',
{badarg,
[{persistent_term,get,
[tcp_listener_helper_result],
[{error_info,#{module => erl_erts_errors}}]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},
persistent_term,get,
[tcp_listener_helper_result]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{tcp_listener_SUITE,inet_sockname_returns_error,1,
[{file,
"/home/circleci/project/big_tests/tests/tcp_listener_SUITE.erl"},
{line,81}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}mssql_mnesia_27 / odbc_mssql_mnesia / 00a4c4b cockroachdb_cets_27 / cockroachdb_cets / 00a4c4b pgsql_mnesia_26 / pgsql_mnesia / 00a4c4b pgsql_mnesia_27 / pgsql_mnesia / 00a4c4b mysql_redis_27 / mysql_redis / 00a4c4b |
Services in the context of MongooseIM means something else. Avoid the confusion and call them all "components" as XMPP does (https://xmpp.org/extensions/xep-0114.html).