Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimisations and cleanups #4480

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Minor optimisations and cleanups #4480

merged 3 commits into from
Feb 7, 2025

Conversation

NelsonVides
Copy link
Collaborator

See commits for details, most changes are self-explanatory.

@NelsonVides
Clean usage of jlib:replace_from_to*
9320a70 
Prefer modifying the whole package instead of manually inspecting
attributes. Also optimise what is removed and what is replaced.
@NelsonVides
Optimise gen_servers
88952f6 
- introduce hibernation when appropriate,
- remove dead `code_change/3` callbacks,
- remove dead comments,
- improve specs for start_link/ and init/1 callbacks
@NelsonVides
Add xmpp_router behaviour specs to implementations
cf0c309
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 5, 2025 •
edited
Loading

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / cf0c309
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

small_tests_26 / small_tests / cf0c309
Reports root / small

small_tests_27 / small_tests / cf0c309
Reports root / small

small_tests_27_arm64 / small_tests / cf0c309
Reports root / small

ldap_mnesia_27 / ldap_mnesia / cf0c309
Reports root/ big
OK: 2295 / Failed: 0 / User-skipped: 1022 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / cf0c309
Reports root/ big
OK: 2295 / Failed: 0 / User-skipped: 1007 / Auto-skipped: 0

dynamic_domains_mysql_redis_27 / mysql_redis / cf0c309
Reports root/ big
OK: 4809 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / cf0c309
Reports root/ big
OK: 4580 / Failed: 22 / User-skipped: 118 / Auto-skipped: 243

connect_SUITE:session_replacement:replaced_session_cannot_terminate_different_nodes 
{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,#{},\n                  [{xmlel,<<\"host-unknown\">>,\n                     #{<<\"xmlns\">> =>\n                       <<\"urn:ietf:params:xml:ns:xmpp-streams\">>},\n                     []}]}",
    [{escalus_session,assert_stream_features,3,
              [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,294}]},
     {escalus_session,stream_features,2,
              [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,193}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,171}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,2151}]},
     {escalus_connection,start,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,155}]},
     {connect_SUITE,replaced_session_cannot_terminate_different_nodes,1,
            [{file,"/home/circleci/project/big_tests/tests/connect_SUITE.erl"},
             {line,585}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]}]}}

Report log

graphql_last_SUITE:admin_http:admin_last_configured:admin_old_users:admin_user_without_last_info_is_old_user 
{error,{{assertEqual,[{module,graphql_last_SUITE},
            {line,421},
            {expression,"length ( OldUsers )"},
            {expected,3},
            {value,2}]},
    [{graphql_last_SUITE,admin_user_without_last_info_is_old_user,1,
               [{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
                {line,421}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_last_SUITE:admin_cli:admin_last_configured:admin_old_users:admin_user_without_last_info_is_old_user 
{error,{{assertEqual,[{module,graphql_last_SUITE},
            {line,421},
            {expression,"length ( OldUsers )"},
            {expected,3},
            {value,2}]},
    [{graphql_last_SUITE,admin_user_without_last_info_is_old_user,1,
               [{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
                {line,421}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_session_SUITE:admin_session:admin_session_http:admin_list_sessions 
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,299},
      {expression,"length ( Sessions )"},
      {expected,3},
      {value,4}]},
   [{graphql_session_SUITE,admin_list_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,299}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,75}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1303}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_session_SUITE:admin_session:admin_session_http:admin_count_sessions 
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,321},
      {expression,"Number"},
      {expected,3},
      {value,4}]},
   [{graphql_session_SUITE,admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,321}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,75}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1303}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_session_SUITE:admin_session:admin_session_cli:admin_list_sessions 
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,299},
      {expression,"length ( Sessions )"},
      {expected,3},
      {value,4}]},
   [{graphql_session_SUITE,admin_list_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,299}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,75}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1303}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_session_SUITE:admin_session:admin_session_cli:admin_count_sessions 
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,321},
      {expression,"Number"},
      {expected,3},
      {value,4}]},
   [{graphql_session_SUITE,admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,321}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,75}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1303}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_session_SUITE:domain_admin_session:domain_admin_list_sessions 
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,155},
      {expression,"length ( Sessions )"},
      {expected,2},
      {value,3}]},
   [{graphql_session_SUITE,domain_admin_list_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,155}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,75}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1303}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_session_SUITE:domain_admin_session:domain_admin_count_sessions 
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,174},
      {expression,"Number"},
      {expected,2},
      {value,3}]},
   [{graphql_session_SUITE,domain_admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,174}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,75}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1303}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_http:admin_stats_global_test 
{error,{{assertEqual,[{module,graphql_stats_SUITE},
            {line,83},
            {expression,"OnlineUsers"},
            {expected,0},
            {value,1}]},
    [{graphql_stats_SUITE,admin_stats_global_test,1,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,83}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_http:admin_stats_global_with_users_test 
{error,{{assertEqual,[{module,graphql_stats_SUITE},
            {line,98},
            {expression,"OnlineUsers"},
            {expected,1},
            {value,2}]},
    [{graphql_stats_SUITE,admin_stats_global_with_users_test,2,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,98}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_http:admin_stats_domain_test 
{error,{{assertMatch,[{module,graphql_stats_SUITE},
            {line,104},
            {expression,"Result1"},
            {pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
            {value,#{<<"onlineUsers">> => 1,
                 <<"registeredUsers">> => 0}}]},
    [{graphql_stats_SUITE,admin_stats_domain_test,1,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,104}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_http:admin_stats_domain_with_users_test 
{error,{{assertMatch,[{module,graphql_stats_SUITE},
            {line,113},
            {expression,"Result1"},
            {pattern,"# { << \"registeredUsers\" >> := 1 , << \"onlineUsers\" >> := 1 }"},
            {value,#{<<"onlineUsers">> => 2,
                 <<"registeredUsers">> => 1}}]},
    [{graphql_stats_SUITE,admin_stats_domain_with_users_test,2,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,113}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_cli:admin_stats_global_test 
{error,{{assertEqual,[{module,graphql_stats_SUITE},
            {line,83},
            {expression,"OnlineUsers"},
            {expected,0},
            {value,1}]},
    [{graphql_stats_SUITE,admin_stats_global_test,1,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,83}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_cli:admin_stats_global_with_users_test 
{error,{{assertEqual,[{module,graphql_stats_SUITE},
            {line,98},
            {expression,"OnlineUsers"},
            {expected,1},
            {value,2}]},
    [{graphql_stats_SUITE,admin_stats_global_with_users_test,2,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,98}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_cli:admin_stats_domain_test 
{error,{{assertMatch,[{module,graphql_stats_SUITE},
            {line,104},
            {expression,"Result1"},
            {pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
            {value,#{<<"onlineUsers">> => 1,
                 <<"registeredUsers">> => 0}}]},
    [{graphql_stats_SUITE,admin_stats_domain_test,1,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,104}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:admin_stats_cli:admin_stats_domain_with_users_test 
{error,{{assertMatch,[{module,graphql_stats_SUITE},
            {line,113},
            {expression,"Result1"},
            {pattern,"# { << \"registeredUsers\" >> := 1 , << \"onlineUsers\" >> := 1 }"},
            {value,#{<<"onlineUsers">> => 2,
                 <<"registeredUsers">> => 1}}]},
    [{graphql_stats_SUITE,admin_stats_domain_with_users_test,2,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,113}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:domain_admin_stats:admin_stats_domain_test 
{error,{{assertMatch,[{module,graphql_stats_SUITE},
            {line,104},
            {expression,"Result1"},
            {pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
            {value,#{<<"onlineUsers">> => 1,
                 <<"registeredUsers">> => 0}}]},
    [{graphql_stats_SUITE,admin_stats_domain_test,1,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,104}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_stats_SUITE:domain_admin_stats:admin_stats_domain_with_users_test 
{error,{{assertMatch,[{module,graphql_stats_SUITE},
            {line,113},
            {expression,"Result1"},
            {pattern,"# { << \"registeredUsers\" >> := 1 , << \"onlineUsers\" >> := 1 }"},
            {value,#{<<"onlineUsers">> => 2,
                 <<"registeredUsers">> => 1}}]},
    [{graphql_stats_SUITE,admin_stats_domain_with_users_test,2,
                [{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
                 {line,113}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

metrics_session_SUITE:session_global:session_global 
{error,{test_case_failed,"Incorrect number of instrumentation events - matched: 0, expected: positive"}}

Report log

metrics_session_SUITE:end_per_suite 
{error,{test_case_failed,"Instrumentation events that were logged, but not tested:\n[{sm_node_sessions,#{}},{sm_total_sessions,#{}},{sm_unique_sessions,#{}}]\nYou need to test them with instrument_helper:assert/3"}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster 
{failed,
  {graphql_server_SUITE,end_per_testcase,
    {'EXIT',
      {{badrpc,nodedown},
       [{distributed_helper,rpc,
          [#{node => mongooseim3@localhost},
           mnesia,system_info,
           [is_running]],
          [{file,
             "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
           {line,140}]},
        {distributed_helper,has_mnesia,1,
          [{file,
             "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
           {line,31}]},
        {distributed_helper,remove_node_from_cluster,2,
          [{file,
             "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
           {line,53}]},
        {graphql_server_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
           {line,121}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1638}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1346}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1235}]}]}}}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:remove_node_test 
{error,{#{what => invalid_response_code,expected_type => ok,
      response_code => {exit_status,3}},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,258}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,241}]},
     {graphql_server_SUITE,remove_node_test,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,225}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:stop_node_test 
{error,{#{what => invalid_response_code,expected_type => ok,
      response_code => {exit_status,3}},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,258}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,241}]},
     {graphql_server_SUITE,stop_node_test,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,230}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

last_SUITE:init_per_suite 
{fail,[{validate_node_failed,{badrpc,nodedown},mongooseim3@localhost}]}

Report log

6 errors were truncated

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / cf0c309
Reports root/ big
OK: 4844 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / cf0c309
Reports root/ big
OK: 4829 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

pgsql_cets_27 / pgsql_cets / cf0c309
Reports root/ big
OK: 4914 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0

internal_mnesia_27 / internal_mnesia / cf0c309
Reports root/ big
OK: 2429 / Failed: 0 / User-skipped: 888 / Auto-skipped: 0

mysql_redis_27 / mysql_redis / cf0c309
Reports root/ big
OK: 5196 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / cf0c309
Reports root/ big
OK: 5202 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

cockroachdb_cets_27 / cockroachdb_cets / cf0c309
Reports root/ big
OK: 4917 / Failed: 1 / User-skipped: 188 / Auto-skipped: 0

pubsub_SUITE:dag+node_affiliations:deny_no_owner_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_deny_no_owner_test_3157@localhost/res1">>,
          escalus_tcp,<0.106104.0>,
          [{event_manager,<0.106102.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_deny_no_owner_test_3157">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.106102.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_deny_no_owner_test_3157">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_deny_no_owner_test_3157">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,<<"alicE_deny_no_owner_test_3157">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"3cb82a753650358f">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,425}]},
     {escalus_story,story,4,
       [{file,
          "...

Report log

pgsql_mnesia_27 / pgsql_mnesia / cf0c309
Reports root/ big
OK: 5217 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

mssql_mnesia_27 / odbc_mssql_mnesia / cf0c309
Reports root/ big
OK: 5212 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / cf0c309
Reports root/ big
OK: 405 / Failed: 3 / User-skipped: 36 / Auto-skipped: 0

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (a610a89) to head (cf0c309).
Report is 4 commits behind head on feature/listeners.

Files with missing lines Patch % Lines
src/ejabberd_router.erl 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                  @@
##           feature/listeners    #4480      +/-   ##
=====================================================
+ Coverage              85.48%   85.51%   +0.02%     
=====================================================
  Files                    558      558              
  Lines                  33971    33958      -13     
=====================================================
- Hits                   29041    29040       -1     
+ Misses                  4930     4918      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides marked this pull request as ready for review February 5, 2025 13:35
chrzaszcz
chrzaszcz approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok 👍

@chrzaszcz chrzaszcz merged commit 24ba096 into feature/listeners Feb 7, 2025
4 checks passed
@chrzaszcz chrzaszcz deleted the minor_optimisations_and_cleanups branch February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NelsonVides @mongoose-im @chrzaszcz