Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid recursion in format/lint #487

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Jul 19, 2024

What is the purpose of this pull request?

  • Other, please explain:

What changes did you make? (Give an overview)

Fixes an npm linting script

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (04b27b1).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       660   +11     
  Branches       250       246    -4     
=========================================
+ Hits           649       660   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@voxpelli
Copy link
Member

What is the actual fix here? :)

There is one difference here, it's that the report flag is not in the format script?

@brettz9
Copy link
Member Author

brettz9 commented Jul 19, 2024

Sorry, this is now being called recursively. format was calling lint. lint calls lint:* which includes lint:eslint-docs which runs format again. Calling just eslint avoids the circle.

package.json Show resolved Hide resolved
@voxpelli voxpelli merged commit 46667d3 into eslint-community:main Jul 19, 2024
17 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9 brettz9 deleted the recursive-script branch July 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants