This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Update: add ImportExpression #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kaicataldo
approved these changes
Jul 14, 2019
|
estree/estree#198 has been merged. This PR is important to get ESlint to support dynamic imports. Please consider it |
platinumazure
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
LGTM!
@mysticatea, does this still match what happened in ESTree? (It looks good to me, but would appreciate you double-checking)
|
Yes, this PR matches the ESTree update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ImportExpressionnode for dynamic import syntax.Don't merge this PR til estree/estree#198 was merged.