Using --max-warnings in combination with --quiet should error

[gewoonwoutje]

The version of ESLint you are using.
v7.21.0

The problem you want to solve.
Using the --max-warnings cli option is useless in combination with --quiet.
I'm running this in

Note the following, first running without --quiet, then with.

Your take on the correct solution to problem.

Ideally: The --quiet flag should be overriden when the amount of warnings exceeds max-warnings, logging the warnings.
Also acceptable: The exit code should be 1 when max-warnings is exceeded.

Are you willing to submit a pull request to implement this change?
Not really 😇

[nzakas]

It looks like there is probably a bug when quiet and max-warnings are used together. In that case, it should still exit with a 1 exit code saying that there were too many warnings.

I think it makes sense to not show warnings in this case.

[mdjermanovic]

It looks like there is probably a bug when quiet and max-warnings are used together. In that case, it should still exit with a 1 exit code saying that there were too many warnings.

I agree that --max-warnings indicates that the user wants a non-zero exit code when there are too many warnings, even with --quiet. Otherwise, this combination wouldn't make sense, and if a non-zero exit code isn't desired behavior then they can just remove --max-warnings from the command.

I think it makes sense to not show warnings in this case.

I don't have a strong opinion on this. Not showing warnings looks less surprising, but the list of warnings might be valuable in this case.

[btmills]

I agree that this is a bug and that --max-warnings should trigger a non-zero exit code when the limit is exceeded even if used with --quiet.

I think it makes sense to not show warnings in this case.

I also agree that this is the correct behavior because we should respect --quiet and not show warnings even if --max-warnings is exceeded.

[nzakas]

Okay, so it sounds like we've agreed that the current behavior is a bug.

Current behavior: When using --quiet with --max-warnings, we are not showing an error even when the number of warnings exceeds the threshold for errors.

Desired behavior: When using --quiet with --max-warnings, we should show the error that the maximum number of warnings has been reached and not show the actual warnings.

[mdjermanovic]

Should we show the number of found warnings in the message?

Current message is: ESLint found too many warnings (maximum: 100).

eslint/lib/cli.js

Lines 315 to 318 in ebd7026

	log.error(
	"ESLint found too many warnings (maximum: %s).",
	options.maxWarnings
	);

Without --quiet, formatter is expected to show the number of warnings.

With --quiet, formatter will show either nothing or, if it's a formatter that always show a summary, something like warnings: 0.

[nzakas]

I don’t think that’s necessary. The max allowable warnings is already shown so I don’t think there’s any need to show the actual number