Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Return value of applyInlineConfig() #18623

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 24, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refactor

What changes did you make? (Give an overview)

I've been trying to tighten up the expected interfaces for language plugins, and I realized that the node property on inline configs is actually never used except to retrieve the location, so I switched the interface to just return loc instead.

Is there anything you'd like reviewers to focus on?

I can't think of a scenario where we'd need anything other than the loc, but let me know if I've missed something.

@nzakas nzakas requested a review from a team as a code owner June 24, 2024 16:00
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 24, 2024
@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 616f311
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6679983ba83811000825c023

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 24, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 69ff64e into main Jun 24, 2024
19 checks passed
@mdjermanovic mdjermanovic deleted the lang-refactors branch June 24, 2024 18:05
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 22, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants