-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update globals to version 13.6 #32
Conversation
Hi @realityking!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
1 similar comment
Hi @realityking!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
This matches the version required by eslint and allows for deduplication
package.json
Outdated
@@ -50,7 +50,7 @@ | |||
"ajv": "^6.12.4", | |||
"debug": "^4.1.1", | |||
"espree": "^7.3.0", | |||
"globals": "^12.1.0", | |||
"globals": "^13.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
globals is up to 13.9 now, which is still compatible with the version defined in eslint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Could this be made available with a minor or patch release? |
Yes, this will be released tomorrow. |
This matches the version required by eslint and allows for deduplication
The upgrade commit for eslint is 5ad91aa7df3d6bc185786e6eccd9e055fd951055
Deduplication will help with eslint/eslint#14098