Breaking: Switch to ESM (fixes #35) #39

brettz9 · 2021-06-25T14:42:39Z

Fixes #35.

Breaking: Switch to ESM; fixes Convert package to ESM #35
Build: Align Rollup with eslint-scope
Chore: Update devDeps.
Chore: Fix a YAML parsing test (was failing in main)

Note that I converted CommonJS files to use the cjs extension as per type: module.

I can align this to any file changes on #37.

eslint-github-bot · 2021-06-25T14:42:42Z

Hi @brettz9!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The commit message tag must be one of the following:

The Tag is one of the following:
- Fix - for a bug fix.
- Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
- New - implements a new feature.
- Breaking - for a backwards-incompatible enhancement or feature.
- Docs - changes to documentation only.
- Build - changes to build process only.
- Upgrade - for a dependency upgrade.
- Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).
You can use the labels of the issue you are working on to determine the best tag.
There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

eslint-github-bot · 2021-06-25T14:43:21Z

Hi @brettz9!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The commit message tag must be one of the following:

The Tag is one of the following:
- Fix - for a bug fix.
- Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
- New - implements a new feature.
- Breaking - for a backwards-incompatible enhancement or feature.
- Docs - changes to documentation only.
- Build - changes to build process only.
- Upgrade - for a dependency upgrade.
- Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).
You can use the labels of the issue you are working on to determine the best tag.
There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

aladdin-add

It make senses to covert conf/* to esm

.eslintrc.cjs

lib/shared/relative-module-resolver.js

brettz9 · 2021-07-03T08:49:17Z

It make senses to covert conf/* to esm

It will force a change to the API; in particular in ./lib/config-array-factory.js, loadConfigFile is called at run-time by loadInDirectory and various other methods through _loadConfigData. loadConfigFile in turn calls loadJSConfigFile and then importFresh with no Promises/async being in use.

See discussion beginning at #35 (comment)

nzakas · 2021-07-10T00:35:34Z

We for sure don’t want to change the API. The API overall is frozen, so anything we can do to avoid changes is important.

…sion, except tests/fixtures/rules/make-syntax-error-rule.js given that ModuleResolve uses the Node Resolution Algorithm

… a plugin at least), so create require

…llup config, and align it with eslint-scope

brettz9 · 2021-07-17T22:06:20Z

I think this is ready for further review. It keeps the old API by using CommonJS for the conf files.

nzakas · 2021-07-28T00:46:23Z

Thanks. This is on my todo list to review!

mdjermanovic

Prepared eslint/eslint#14865, which currently uses this branch. That should be a good test for these changes.

mdjermanovic · 2021-08-01T22:00:16Z

lib/index.js

+const Legacy = {
+    ConfigArray,
+    createConfigArrayFactoryContext,
+    CascadingConfigArrayFactory,
+    ConfigArrayFactory,
+    ConfigDependency,
+    ExtractedConfig,
+    IgnorePattern,
+    OverrideTester,
+    getUsedExtractedConfigs,
+
+    // shared
+    ConfigOps,
+    ConfigValidator,
+    ModuleResolver,
+    naming
+};


It seems we should add environments here since ESLint needs that:

https://github.com/eslint/eslint/blob/e31f49206f94e2b3977ec37892d4b87ab1e46872/lib/linter/linter.js#L19

The exported name could be BuiltInEnvironments?

I'll add that.

lib/shared/config-validator.js

.github/workflows/ci.yml

tests/_utils/index.js

package.json

Co-authored-by: Milos Djermanovic <[email protected]>

nzakas

This looks really good @brettz9! Thanks so much for all of the hard work.

nzakas · 2021-08-04T17:32:41Z

lib/index.js

+const Legacy = {
+    ConfigArray,
+    createConfigArrayFactoryContext,
+    CascadingConfigArrayFactory,
+    ConfigArrayFactory,
+    ConfigDependency,
+    ExtractedConfig,
+    IgnorePattern,
+    OverrideTester,
+    getUsedExtractedConfigs,
+
+    // shared
+    ConfigOps,
+    ConfigValidator,
+    ModuleResolver,
+    naming
+};


I'll add that.

eslint-github-bot bot added the triage label Jun 25, 2021

brettz9 changed the title ~~ESM~~ Breaking: Switch to ESM Jun 25, 2021

brettz9 changed the title ~~Breaking: Switch to ESM~~ Breaking: Switch to ESM (fixes #35) Jun 25, 2021

aladdin-add requested changes Jul 3, 2021

View reviewed changes

.eslintrc.cjs Outdated Show resolved Hide resolved

lib/shared/relative-module-resolver.js Outdated Show resolved Hide resolved

aladdin-add marked this pull request as draft July 3, 2021 08:15

aladdin-add marked this pull request as ready for review July 3, 2021 09:05

aladdin-add self-requested a review July 3, 2021 09:12

brettz9 added 12 commits July 10, 2021 09:08

Breaking: Switch to ESM

2109bf7

Fix: CJS changes

21dd692

Fix: Though tests in prev. commit passed, change all CJS to cjs exten…

48cc8bb

…sion, except tests/fixtures/rules/make-syntax-error-rule.js given that ModuleResolve uses the Node Resolution Algorithm

Fix: Rollup did not like requiring of default module.exports (without…

098614e

… a plugin at least), so create require

New: Add exports; also update devDeps. specify external modules in Ro…

54238ea

…llup config, and align it with eslint-scope

Fix: Add dist file

74422b7

Fix: We can use cjs for our final file after all

a5f67fa

Test: CommonJS

2b4d3ed

Refactor: Drop Node overrides while still using non-ESM config

ea9ecf0

Refactor: Drop Module.createRequireFromPath

1dba2ce

Test: Supply Node version which won't fail with dev.

cc9201d

Fix: Windows needs file: for absolute URLs

8f4da05

brettz9 force-pushed the esm branch from 3db3c7e to 8f4da05 Compare July 10, 2021 01:08

brettz9 added 2 commits July 10, 2021 09:21

Refactor: Remove line break

9fc1c1d

Fix: Convert further paths to file: imports for Windows

2dc89d3

brettz9 force-pushed the esm branch from 3acf49c to 2dc89d3 Compare July 17, 2021 22:00

Fix: Point main to CJS for older browsers

eaf487f

Chore: update devDeps

0b27173

mdjermanovic mentioned this pull request Aug 1, 2021

Upgrade: @eslint/[email protected] eslint/eslint#14865

Merged

3 tasks

mdjermanovic requested changes Aug 1, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

tests/_utils/index.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

brettz9 and others added 4 commits August 2, 2021 08:01

Update .github/workflows/ci.yml

d0ce859

Co-authored-by: Milos Djermanovic <[email protected]>

Update tests/_utils/index.js

dd84334

Co-authored-by: Milos Djermanovic <[email protected]>

Update package.json

db7d69f

Co-authored-by: Milos Djermanovic <[email protected]>

Refactor: Switch two of the conf files to ESM

f401442

nzakas approved these changes Aug 4, 2021

View reviewed changes

nzakas merged commit bdce01a into eslint:main Aug 4, 2021

nzakas mentioned this pull request Aug 4, 2021

Update: Export environments #46

Merged

brettz9 deleted the esm branch August 4, 2021 23:03

mdjermanovic mentioned this pull request Aug 5, 2021

ESLint Browser Test fails #50

Closed

legobeat mentioned this pull request May 1, 2023

Drop or patch dependency import-fresh #110

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Breaking: Switch to ESM (fixes #35) #39

Breaking: Switch to ESM (fixes #35) #39

brettz9 commented Jun 25, 2021 •

edited

Loading

eslint-github-bot bot commented Jun 25, 2021

eslint-github-bot bot commented Jun 25, 2021

aladdin-add left a comment

brettz9 commented Jul 3, 2021

nzakas commented Jul 10, 2021

brettz9 commented Jul 17, 2021

nzakas commented Jul 28, 2021

mdjermanovic left a comment

mdjermanovic Aug 1, 2021

nzakas Aug 4, 2021

nzakas left a comment

nzakas Aug 4, 2021

Breaking: Switch to ESM (fixes #35) #39

Breaking: Switch to ESM (fixes #35) #39

Conversation

brettz9 commented Jun 25, 2021 • edited Loading

eslint-github-bot bot commented Jun 25, 2021

eslint-github-bot bot commented Jun 25, 2021

aladdin-add left a comment

Choose a reason for hiding this comment

brettz9 commented Jul 3, 2021

nzakas commented Jul 10, 2021

brettz9 commented Jul 17, 2021

nzakas commented Jul 28, 2021

mdjermanovic left a comment

Choose a reason for hiding this comment

mdjermanovic Aug 1, 2021

Choose a reason for hiding this comment

nzakas Aug 4, 2021

Choose a reason for hiding this comment

nzakas left a comment

Choose a reason for hiding this comment

nzakas Aug 4, 2021

Choose a reason for hiding this comment

brettz9 commented Jun 25, 2021 •

edited

Loading