Upgrade: [email protected] #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
commented
Feb 5, 2019
| "column": 30, | ||
| "message": "The keyword 'yield' is reserved" |
kaicataldo
force-pushed
the
espree-upgrade
branch
from
5c75628 to
9249e11
Compare
kaicataldo
force-pushed
the
espree-upgrade
branch
from
3985b98 to
9df237d
Compare
kaicataldo
commented
Feb 6, 2019
| @@ -1,87 +1,179 @@ | |||
| module.exports = { | |||
| "type": "Program", | |||
| "start": 0, | |||
There was a problem hiding this comment.
I'm noticing these are new after updating these tests. It looks like Acorn has been adding the "start" and "end" properties to the Program node for a while, so I'm not sure why they were missing here.
mysticatea
approved these changes
Feb 8, 2019
not-an-aardvark
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected] is now fully ECMA-262-compliant!
There are two types of test changes included:
I had trouble getting our existing
tools/update-tests.jsscript to work, so I ended up just running Espree over the code snippets and updating them manually. I'll try to find some time in the future to look at the scripts and see if I can get them to work - I seem to remember that being an issue last time I tried to update tests too.