Failed to import - postcss-nested

[kidonng]

Failing module

• GitHub: https://github.com/postcss/postcss-nested
• npm: https://www.npmjs.com/package/postcss-nested

import postcss from 'https://esm.sh/[email protected]'
import nested from 'https://esm.sh/[email protected]'

const {css} = postcss([nested]).process(`
.a {
	color: blue;

	& .b {
		color: red;
	}
}
`)

console.log(css)

Error message

After running deno run I got this:

error: Uncaught TypeError: _ is not a function
    at v (https://esm.sh/v92/[email protected]/deno/postcss-nested.js:2:998)
    at https://esm.sh/v92/[email protected]/deno/postcss-nested.js:2:1397
    at Array.forEach (<anonymous>)
    at x (https://esm.sh/v92/[email protected]/deno/postcss-nested.js:2:1379)
    at https://esm.sh/v92/[email protected]/deno/postcss-nested.js:2:2454
    at https://esm.sh/v92/[email protected]/deno/postcss.js:24:5129
    at M.each (https://esm.sh/v92/[email protected]/deno/postcss.js:24:1199)
    at Proxy.<anonymous> (https://esm.sh/v92/[email protected]/deno/postcss.js:24:5088)
    at Rule (https://esm.sh/v92/[email protected]/deno/postcss-nested.js:2:2365)
    at C.visitSync (https://esm.sh/v92/[email protected]/deno/postcss.js:26:11276)

Additional info

• esm.sh version: v92
• Deno version: 1.25.0

I noticed the following code:

let parser = require('postcss-selector-parser')

...is transformed into:

import * as __postcss_selector_parser$ from "/v92/[email protected]/deno/postcss-selector-parser.js";

Which is not correct all the time, for example when the default export is a function with properties. postcss-nested uses both of them:

  // This is where error happens
  let saver = parser(parsed => {
    nodes = parsed
  })

// ...

node.prepend(parser.combinator({ value: ' ' }))

In comparison, Skypack is transforming is correctly:

// https://cdn.skypack.dev/-/[email protected]/dist=es2019,mode=imports/optimized/postcss-nested.js
import parser from "/-/[email protected]/dist=es2019,mode=imports/optimized/postcss-selector-parser.js";

[kidonng]

@ije Kindly ping because I feel this is a serious issue. I also tried past versions, and got the same error since v72 (well, v71 does give the same transformed import, but a new error also appeared).

[kidonng]

I see, so there's a hard-coded list fixing these errors. I wish we can have a better solution in the future.

In the meantime, you may want to also add conf into the list, which is reported in #410.