Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix arch for darwin arm64 #617

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix arch for darwin arm64 #617

merged 1 commit into from
Apr 29, 2023

Conversation

JLugagne
Copy link
Contributor

@JLugagne JLugagne commented Apr 28, 2023 •
edited
Loading

Improve automatic detection to handle arm64. It was not working on darwin/arm64.

ije
ije approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@ije ije merged commit 60f8c6e into esm-dev:main Apr 29, 2023
@JLugagne JLugagne deleted the fix_arch branch April 29, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ije ije ije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JLugagne @ije