Add scope to config #636
Merged
Add scope to config #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ije
reviewed
May 19, 2023
server/build.go
Outdated
| @@ -45,6 +45,15 @@ type BuildTask struct { | |||
| stage string | |||
| } | |||
|
|
|||
| func removeHttpPrefix(s string) (string, error) { | |||
There was a problem hiding this comment.
i would like to put this function in utils.go
There was a problem hiding this comment.
That makes sense, I'll move this.
ije
reviewed
May 19, 2023
| if cfg.NpmRegistryScope != "" { | ||
| isInScope := strings.HasPrefix(name, cfg.NpmRegistryScope) | ||
| if !isInScope { | ||
| url = "https://registry.npmjs.org/" + name |
There was a problem hiding this comment.
can you explain this line a bit? thanks
There was a problem hiding this comment.
This is reproducing what npm does when you have a scope, where if the package you are trying to download is in the scope it goes to one registry and if it's not it goes to the default public registry.
|
No problem, thanks for the prompt review! |
|
hi @johnpangalos would you like to update the config.example.jsonc for the new config? |
|
I can do that! |
|
thanks! |
johnpangalos
added a commit
to johnpangalos/esm.sh
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case: Hosting private npm packages in a custom npm registry, like GitHub's npm registry, and that npm registry is not a mirror.
Issue: When using a custom npm registry you set the
npmRegistryin the config and it downloads the correct npm package, but if you try and download any other package (such as a dependency) it fails because the custom npm registry does not contain any packages but private ones.Solution: Use scope in the
.npmrc, this seemed the easiest since the.npmrcfile was being created anyway.Not sure how to test this, any advice about that would be appreciated.