Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dts transform for imports with both default and named imports #675

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Fix dts transform for imports with both default and named imports #675

merged 1 commit into from
Jul 2, 2023

Conversation

hayes
Copy link
Contributor

@hayes hayes commented Jul 2, 2023

No description provided.

ije
ije approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix to me! thanks~

@ije ije merged commit 64985de into esm-dev:main Jul 2, 2023
@hayes
Copy link
Contributor Author

hayes commented Jul 2, 2023

Thanks for the quick review/merge.

When this gets deployed to global cdn will it invalidate the existing cache, or will this only apply to newly built packages?

@ije
Copy link
Member

ije commented Jul 2, 2023

new deployment purges the CDN cache automatically, will let you know after deploying

@hayes
Copy link
Contributor Author

hayes commented Jul 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ije ije ije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayes @ije