Merge pull request ocsigen#906 from MisterDA/windows-createprocess-le…

…ak-dev-null

Fix win32_spawn leaking dev_null fd in the parent process

CHANGES

@@ -1,3 +1,9 @@
+===== dev =====
+
+====== Fixes ======
+
+  * Fix win32_spawn leaking dev_null fd in the parent process. (#906, Antonin Décimo)
+
 ===== 5.5.0 =====
 
 ====== Deprecations ======

src/unix/lwt_process.ml

@@ -91,15 +91,21 @@ let win32_spawn
       (if prog = "" then None else Some prog) cmdline env cwd
       (stdin_fd, stdout_fd, stderr_fd)
   in
-  let close = function
+  let close fd fd' =
+    match fd with
     | `FD_move fd ->
       Unix.close fd
+    | `Dev_null ->
+      begin match fd' with
+        | Some fd' -> Unix.close fd'
+        | None -> assert false
+      end
     | _ ->
       ()
   in
-  close stdin;
-  close stdout;
-  close stderr;
+  close stdin stdin_fd;
+  close stdout stdout_fd;
+  close stderr stderr_fd;
   proc
 
 external win32_wait_job : Unix.file_descr -> int Lwt_unix.job =