-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory overload fix and more metadata #4
Memory overload fix and more metadata #4
Conversation
Thanks, @orionarcher! This is great - I'll have to look more closely but don't expect to have too many requests for changes. Also yes For the ionic steps: only the energies should be stored by default during MD runs since the full trajectory is saved in blob / GridFS. Do you think we should avoid saving any MD info in |
What would you think of breaking out I think it'd be better to avoid storing trajectory info in ionic_steps, IMO that belongs in the trajectory itself. It also creates a memory issue if accidentally misconfigured. |
@orionarcher I like this solution, I'll merge in your changes and add this feature |
Great! I made a small oversight about how this change would affect the types of the task_doc, fix here. |
In addition to taking a stab at fixing the memory issue, I added some metadata that I'd love to have included. Let me know what you think @esoteric-ephemera.
Summary
Include a summary of major changes in bullet points:
DATA_OBJECTS
so it doesn't surpass MongoDB 16 MB limittags
to task document, can be provided throughtask_document_kwargs
Questions
Is
task_document_kwargs
around to maintain backwards compability? It seems like it only supports 3-4 kwargs so I wonder if it'd be easier to just list them explicitly. It's hard to know what arguments are available through it or where they will be used.Checklist
Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running
ruff
andruff format
on your new code. This willautomatically reformat your code to PEP8 conventions and fix many linting issues.
Run ruff on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install
and a check will be run prior to allowing commits.