Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/max1704x #135

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Feature/max1704x #135

merged 13 commits into from
Jan 9, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 27, 2023

Description

  • Add Max1704x component with example
  • Update and rebuild docs
  • Update CI

Motivation and Context

Battery fuel gauges are pretty cheap and allow high-fidelity monitoring of battery status over I2C, so adding support for them is pretty straightforward. They are even provided via Adafruit:
https://learn.adafruit.com/adafruit-max17048-lipoly-liion-fuel-gauge-and-battery-monitor/overview. I have also added one of these chips to the design of the ESP-BOX-EMU project, so creating the component within espp supports a broader use.

How has this been tested?

Building and running the example on a QtPy ESP32S3 connected to an adafruit dev board for the Max17048.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-01-09 at 08 24 25

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added enhancement New feature or request max1704x battery labels Dec 27, 2023
Copy link

github-actions bot commented Dec 29, 2023

✅Static analysis result - no issues found! ✅

* Updated charge rate to use int16_t instead of uint16_t to get proper negative values for charge rate
* Updated example to support qtpy ESP32 PICO, QtPy ESP32s3, and custom hardware via menuconfig
@finger563 finger563 merged commit 2fd32ac into main Jan 9, 2024
49 checks passed
@finger563 finger563 deleted the feature/max1704x branch January 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant