Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update std::accumulate use #139

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: Update std::accumulate use #139

merged 1 commit into from
Jan 8, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jan 8, 2024

Description

  • Fix use of std::accumulate in ads7138
  • Fix use of std::accumulate in controller

Motivation and Context

Fixes same bug as #138 that was introduced as part of #137

How has this been tested?

Building the examples.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Fix use of std::accumulate in ads7138
* Fix use of std::accumulate in controller
@finger563 finger563 added bug Something isn't working controller ads7138 labels Jan 8, 2024
@finger563 finger563 merged commit aa3e909 into main Jan 8, 2024
48 checks passed
@finger563 finger563 deleted the fix/controller-ads7138 branch January 8, 2024 23:21
Copy link

github-actions bot commented Jan 8, 2024

✅Static analysis result - no issues found! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ads7138 bug Something isn't working controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant