Fix dev-container templating #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzz
commented
Jan 8, 2025
Comment on lines
-57
to
-59
| # Set default toolchain | ||
| RUN rustup default {{ toolchain }} | ||
|
|
There was a problem hiding this comment.
Setting the default value for rustup appears to irrelevant as the value is overwritten by rust-toolchain.toml.
rustup show
...
esp (overridden by '/home/esp/project-name/rust-toolchain.toml')
...
Removing so there is less confusion for new developers.
SergioGasquez
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
dev-containeroption (set usingesp-generate --chip esp32 -o dev-container your-project) does not generate a valid dev-container configuration. The templated parameters are never substituted, which leads to syntax errors, when opening the container.This PR updates the dev-container.json file template to use the key/value based substitution found in other files.