Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use published edge-* crates #74

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Jan 16, 2025

The edge-* crates got new releases so we can use them instead of the git revs.

However, I wonder if we should include them at all by default?

e.g. edge-dhcp is only useful for AP but I assume that's not very common.

Maybe we should add a hint like # for more networking protocol support visit https://crates.io/crates/edge-net instead?

And it seems those crates are async only - so we shouldn't include them (or the hint) if we don't generate for async?

I'm open to suggestions and happy to change this PR accordingly

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Jan 16, 2025
@SergioGasquez
Copy link
Member

And it seems those crates are async only - so we shouldn't include them (or the hint) if we don't generate for async?

I think we need them even if its not async, otherwise build fails due to the changes on smoltcp features iirc.

Maybe we should add a hint like # for more networking protocol support visit https://crates.io/crates/edge-net instead?

I like the idea of the hint!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SergioGasquez SergioGasquez added this pull request to the merge queue Jan 16, 2025
Merged via the queue into esp-rs:main with commit 67bd8a0 Jan 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants