Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
edge-*
crates got new releases so we can use them instead of the git revs.However, I wonder if we should include them at all by default?
e.g.
edge-dhcp
is only useful for AP but I assume that's not very common.Maybe we should add a hint like
# for more networking protocol support visit https://crates.io/crates/edge-net
instead?And it seems those crates are async only - so we shouldn't include them (or the hint) if we don't generate for async?
I'm open to suggestions and happy to change this PR accordingly