-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for v5.2 #284
Conversation
4a30f52
to
3db40f3
Compare
Remove this commit when esp-rs/esp-idf-sys#284 is merged. Signed-off-by: Martin Broers <[email protected]>
Remove this commit when esp-rs/esp-idf-sys#284 is merged. Signed-off-by: Martin Broers <[email protected]>
.github/workflows/ci.yml
Outdated
matrix: | ||
target: | ||
- riscv32imc-esp-espidf | ||
- xtensa-esp32-espidf | ||
- xtensa-esp32s2-espidf | ||
- xtensa-esp32s3-espidf | ||
idf-version: | ||
- v4.4.6 | ||
- v5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a practical standpoint, we might remove v5.0 from the CI runs if we add 5.2, to not make it to slow. I think most people either are still on v4.4.6 or on v5.1.2 currently and that will shift more to 5.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. Removed the pipeline build for v5.0.
3db40f3
to
a3f1544
Compare
Hi, @MartinBroers @Vollbrecht This issue only occurs when enable bluetooth and wifi in sdkconfig but only initialize wifi, it is recommended to workaround by editing sdkconfig or initializing bluetooth. |
@MartinBroers What I do not understand from the linked issue is, what is the actual problem?
|
@esp-lrh @ivmarkov I will rework the PR on esp-idf-svc to work without requiring this patch.
Yes, building the examples in esp-idf-svc does NOT work in v5.1.2
Yes, see my reaction above. We need to patch |
a3f1544
to
e57bc87
Compare
Closing as we found a way to do this without patching esp idf for now. |
When implementing support for the newest v5.2 release from espressif, I found espressif/esp-idf#13113 this issue, where they mention we need to apply a patch, or the linker is going to run havoc.
Also, updated the pipeline so it looks more similar to the esp-idf-svc pipeline. This MR is required for esp-rs/esp-idf-svc#365, else that one can't build.