Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Clean up serial_jtag and increase timeout #55

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 23, 2023

cc #53 - this is a sufficient workaround for my application to not generate broken defmt frames.

I suspect the issue with lost bytes is that defmt calls write_bytes in rapid succession and the host may not have enough time to poll the interface between writes. This PR just tries to increase the timeout but there should be better ways to handle this that results in better FIFO utilisation.

@bugadani bugadani marked this pull request as ready for review October 23, 2023 14:40
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Pretty much what I originally had in mind but back then it turned out it worked "good enough" with the very short timeout.

It shouldn't cause problems but if it does, we can still introduce features to select a different timeout

@bjoernQ bjoernQ merged commit 2c156b9 into esp-rs:main Oct 24, 2023
@bugadani bugadani deleted the serial_jtag branch October 24, 2023 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants