Swap out the flasher stubs with the legacy C stubs #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay from the sounds of things we will move forward with these changes, so un-drafting. @SergioGasquez any strong opinions on the serialization format of the stub? |
Both solutions work for me, I think we are ok manually converting them from json to toml as we used to do before (IIRC), also, we dont expect those to change so its basically doing the conversion only once Edit: I didnt check the changes when writing this, I see that you used |
SergioGasquez
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft for now because:
serde_jsonisn't worth it, and we should convert these to TOML instead, but it's easier to update them this way at leastMostly just making sure HIL is still working by opening this now.
Closes #720