Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninstall process #64

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Fix uninstall process #64

merged 3 commits into from
Nov 15, 2022

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Nov 15, 2022 •
edited
Loading

Updating the config file in every step. Reason was mentioned in #39:

for example, the export file deletion fails. Then, it will always fail as Xtensa Rust toolchain was already deleted but the config file was not updated.

@SergioGasquez SergioGasquez linked an issue Nov 15, 2022 that may be closed by this pull request
Improve config file #39
Closed
jessebraham
jessebraham approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment but fine to merge regardless.

src/main.rs Show resolved Hide resolved
@SergioGasquez SergioGasquez merged commit 1393e7e into main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve config file
2 participants
@SergioGasquez @jessebraham