-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native Windows Notifications #170
Conversation
The Windows CI is failing, but it doesn't look like the failure is caused by any changes I made? |
Hey @LiHRaM, Regarding the icon path, I'm going to take a closer look tomorrow, but there could be another way to solve the problem. Regarding the addition of AppId during installation, we'll need to find a way to integrate it with InnoSetup, the packaging system currently used by espanso. But I don't think it will be much of a problem. Thank you very much for your help :) |
No problem! Thanks for maintaining this project, I love it! |
As a note to myself, this seems to solve the issue: rust-lang/rustup#2203 |
Hey @LiHRaM, There is a problem though that I'd like to address before merging it into espanso. Do you have any idea on how to solve it? Thanks for your help :) |
Hey @federico-terzi,
No, I'm not aware of a way to dequeue older notifications in favor of
the latest.
In fact, I'm pretty sure the Windows team considers this a feature.
The easiest thing to do would probably be to consider only showing
notifications for startup/shutdown,
and visually indicate that espanso is disabled/enabled in a different
way.
In any case, there's no option for it in the bindings that I chose, but
maybe there is in the more raw bindings they're built on. (winrt vs
winrt-notifications)
…On Wed, Feb 12, 2020 at 14:42, Federico Terzi ***@***.***> wrote:
Hey @LiHRaM <https://github.com/LiHRaM>,
I finally had a chance to try your request. First of all, great
work, the integration looks super good!
There is a problem though that I'd like to address before merging it
into espanso.
I often toggle espanso on/off, but when I do that with the new
native notification, all the toast messages get queued, so that
instead of updating the notification in realtime, it get delayed by a
few seconds,. This becomes annoying when toggling many times in a
row, as the user keeps receiving notifications for like 30 seconds.
Do you have any idea on how to solve it?
Thanks for your help :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#170>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBAFEP2AXK2C6CQIHZPCH3RCR3OTANCNFSM4KOK43KQ>.
|
Hey @LiHRaM, |
Hey @LiHRaM, Thank you for the help! I'm closing the PR as the new alpha version ships with native windows notifications :) Thank you for pointing me in the right direction :) |
closes #169
Couple of things: In order for native notifications to register as coming from espanso, it needs to register an AppUserModelID during installation.
Currently, winrt_notification provides a workaround by just using Windows PowerShell's ID.
Also, I had to do a little hacking with paths, so that it correctly uses the icon both when developing on Windows, and when the app's been installed.
Screenshot: