Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korjataan väärinymmärrys Suomi.fi REST salasanan vaihdossa #5917

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Gekkio
Copy link
Contributor

@Gekkio Gekkio commented Nov 5, 2024

/v1/change-password:

  • palauttaa 400 jos access token on vanhentunut -> okhttp:n authenticator-mekanismi ei toimi koska se vaatii 401-koodin
  • ei näytä käyttävän Authorization-headeria ollenkaan

⬇️

Skipataan access token cache kokonaan ja haetaan aina uusi ennen salasanan vaihtoa

This endpoint seems to return 400 when an invalid access token is sent,
and doesn't even use the Authorization header
@Gekkio Gekkio added the bug Korjaus olemassa olevaan toiminnallisuuteen label Nov 5, 2024
@Gekkio Gekkio marked this pull request as ready for review November 6, 2024 08:52
@Gekkio Gekkio merged commit 1976040 into master Nov 6, 2024
31 checks passed
@Gekkio Gekkio deleted the sfi-password-change-token-handling branch November 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Korjaus olemassa olevaan toiminnallisuuteen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants