Lisätään sijoitusehdotuksen hylkäyksen syy hakemuksen muistiinpanoihin #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wnt
reviewed
Nov 19, 2024
| @@ -786,6 +793,10 @@ data class PlacementProposalConfirmationUpdate( | |||
| val otherReason: String?, | |||
| ) | |||
|
|
|||
| data class AcceptPlacementProposalRequest( | |||
| val rejectReasons: Map<PlacementPlanRejectReason, String> | |||
There was a problem hiding this comment.
Tämän voisi nimetä uudelleen:
Suggested change
| val rejectReasons: Map<PlacementPlanRejectReason, String> | |
| val rejectReasonTranslations: Map<PlacementPlanRejectReason, String> |
Wnt
reviewed
Nov 19, 2024
| .forEach { | ||
| val reason = | ||
| when (it.unitRejectReason) { | ||
| PlacementPlanRejectReason.OTHER -> it.unitRejectOtherReason |
There was a problem hiding this comment.
Pitäiskö tässä prefixata muistiinpanon sisältöä hieman, jotta se on yksiselitteisempi:
Niin, että muistiinpanon sisällöksi tulee esim.
"Sijoitusehdotus hylätty - Päiväkoti täynnä" (Tampere; REASON_1)
"Sijoitusehdotus hylätty - Sisäilma tai muu rakenteellinen syy" (Tampere; REASON_2)
"Sijoitusehdotus hylätty - Muu syy: Emme hyväksy maanantaisin lähetettyjä hakemuksia lainkaan" (OTHER)
Wnt
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kun johtaja hylkää sijoitusehdotuksen ja kirjaa hylkäykseen syyn, teksti katoaa, kun palveluohjaus palauttaa sijoitusehdotuksen sieltä johtajan tarkistettavana tilasta taaksepäin.
Tämän muutoksen myötä palveluohjaus näkee hylkäyksen syyn hakemuksen muistiinpanoista.