-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Päivämääräkentän saavutettavuus #6117
Conversation
</> | ||
) | ||
}) | ||
|
||
interface InternalProps extends Omit<Props, 'useBrowserPicker'> { | ||
ariaId: string | ||
ariaId?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this prop used at all anymore? if not, I think it should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, removed
@@ -269,6 +290,16 @@ export default React.memo(function DatePickerLowLevel({ | |||
minDate={minDate} | |||
maxDate={maxDate} | |||
/> | |||
<StyledIconButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would take a quick look at the employee side too to check if the increased with of this component broke some layouts e.g. in modals where the space is limited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - is there a specific modal where it is an issue that should be checked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure 🤔 Creating a new document template (lomakepohjat ylävalikosta) could be one. Maybe just use 10min to randomly poke around. Not that big of a deal anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4f773cb
to
f711ba8
Compare
Ennen muutosta
Päivämäärävalitsin oli vaikeasti navigoitavissa ruudunlukijan/avusteisen kanssa.
Muutoksen jälkeen
Lisätty erillinen ikoni valitsimen avaamiseen ja asetettu sille aria-haspopup- ja aria-expanded -attribuutit.
Input-kentästä pääsee myös valitsimeen painamalla nuoli alas -näppäintä.
Korvattu erillinen ruudunlukijan ohjeteksti asettamalla se inputin aria-labeliin suoraan.
Videolla käyttöä ensin hiirellä ja sitten näppäimistöllä:
datepicker.mov