Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Päivämääräkentän saavutettavuus #6117

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Päivämääräkentän saavutettavuus #6117

merged 3 commits into from
Dec 12, 2024

Conversation

tomuli
Copy link
Contributor

@tomuli tomuli commented Dec 11, 2024

Ennen muutosta

Päivämäärävalitsin oli vaikeasti navigoitavissa ruudunlukijan/avusteisen kanssa.

Muutoksen jälkeen

Lisätty erillinen ikoni valitsimen avaamiseen ja asetettu sille aria-haspopup- ja aria-expanded -attribuutit.
Input-kentästä pääsee myös valitsimeen painamalla nuoli alas -näppäintä.
Korvattu erillinen ruudunlukijan ohjeteksti asettamalla se inputin aria-labeliin suoraan.

Videolla käyttöä ensin hiirellä ja sitten näppäimistöllä:

datepicker.mov

@tomuli tomuli marked this pull request as ready for review December 12, 2024 07:25
@tomuli tomuli added the enhancement Uusi toiminnallisuus tai parannus label Dec 12, 2024
</>
)
})

interface InternalProps extends Omit<Props, 'useBrowserPicker'> {
ariaId: string
ariaId?: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this prop used at all anymore? if not, I think it should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, removed

@@ -269,6 +290,16 @@ export default React.memo(function DatePickerLowLevel({
minDate={minDate}
maxDate={maxDate}
/>
<StyledIconButton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take a quick look at the employee side too to check if the increased with of this component broke some layouts e.g. in modals where the space is limited

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - is there a specific modal where it is an issue that should be checked?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure 🤔 Creating a new document template (lomakepohjat ylävalikosta) could be one. Maybe just use 10min to randomly poke around. Not that big of a deal anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's "enoughish"(?) space on the citizen modal and e.g. the employee new doc template ->

Screenshot 2024-12-12 at 15 12 56 Screenshot 2024-12-12 at 15 14 31

@tomuli tomuli force-pushed the datefield-popup-aria branch from 4f773cb to f711ba8 Compare December 12, 2024 12:54
@tomuli tomuli merged commit 7b55606 into master Dec 12, 2024
30 checks passed
@tomuli tomuli deleted the datefield-popup-aria branch December 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Uusi toiminnallisuus tai parannus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants