Lisätään työaikakirjaukseen luonti/muokkaustiedot #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wnt
reviewed
Jan 7, 2025
service/src/main/kotlin/fi/espoo/evaka/attendance/MobileRealtimeStaffAttendanceController.kt
Show resolved
Hide resolved
Wnt
reviewed
Jan 7, 2025
| CREATE INDEX fk$staff_attendance_realtime_arrived_added_by ON staff_attendance_realtime (arrived_added_by); | ||
| CREATE INDEX fk$staff_attendance_realtime_arrived_modified_by ON staff_attendance_realtime (arrived_modified_by); | ||
| CREATE INDEX fk$staff_attendance_realtime_departed_added_by ON staff_attendance_realtime (departed_added_by); | ||
| CREATE INDEX fk$staff_attendance_realtime_departed_modified_by ON staff_attendance_realtime (departed_modified_by); |
There was a problem hiding this comment.
Koska arrived tietue on non-nullable staff_attendance_realtime taulussa, niin myös columnit arrived_added_at, arrived_added_by,arrived_modified_at,arrived_modified_by voisi laittaa non-nullableksi migraation lopuksi.
Datan näihin voi alustaa migraatiossa tähän tyyliin:
arrived_added_at = created
arrived_added_by = '00000000-0000-0000-0000-000000000000'::UUID,
arrived_modified_at = COALESCE(updated, created)
arrived_modified_by = '00000000-0000-0000-0000-000000000000'::UUID,
Tämä seuraisi samaa kaavaa, kuin mitä meillä on muissa tauluissa joissa on created_by, modified_at ja modified_by tiedot.
There was a problem hiding this comment.
Mielestäni vanhoille merkinnöille pitäisi jättää NULL:
- jos
arrived_modified_atasetetaan, niin lähes jokaiselle vanhalle saapumisajalle tuleeMuokattu-teksti, vaikka oikeasti sitä ei todennäköisesti ole koskaan muokattu, - jos
arrived_added_atasetetaan (ilmanarrived_modified_at), tulee kaikille vanhoille saapumisajoille pelkkäMerkintä luotu-teksti, joka voi antaa väärän kuvan että sitä ei ole enää myöhemmin muokattu, - taulu on melko iso, joten näiden asettaminen paikoilleen voi kestää hetken.
patari
force-pushed
the
staff-attendance-modified-metadata
branch
from
93a0f28 to
42413a7
Compare
Wnt
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erilliset kentät saapumisen ja lähtemisen tallennukselle. Muokkaustiedot näytetään vain jos ne eroaa luontitiedoista.