Skip to content

Commit

Permalink
Merge branch 'bugfix/storage_generic_pytests' into 'master'
Browse files Browse the repository at this point in the history
fix(ci): Removed storage related entries in known generate test child pipeline warnings

See merge request espressif/esp-idf!35738
  • Loading branch information
rrtandler committed Dec 25, 2024
2 parents 32a5b6e + 91b231a commit 5b15320
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 18 deletions.
1 change: 1 addition & 0 deletions components/nvs_flash/test_apps/pytest_nvs_flash.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

@pytest.mark.esp32
@pytest.mark.esp32c3
@pytest.mark.generic
@pytest.mark.parametrize('config', ['default'], indirect=True)
def test_nvs_flash(dut: IdfDut) -> None:
dut.run_all_single_board_cases(group='!nvs_encr_hmac', timeout=120)
Expand Down
2 changes: 2 additions & 0 deletions components/vfs/test_apps/pytest_vfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
@pytest.mark.esp32c3
@pytest.mark.esp32c6
@pytest.mark.esp32h2
@pytest.mark.generic
@pytest.mark.parametrize('config', [
'default', 'iram',
], indirect=True)
Expand All @@ -16,6 +17,7 @@ def test_vfs_default(dut: Dut) -> None:


@pytest.mark.esp32
@pytest.mark.generic
@pytest.mark.parametrize('config', [
'ccomp',
], indirect=True)
Expand Down
2 changes: 2 additions & 0 deletions components/vfs/test_apps/sdkconfig.defaults
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ CONFIG_PARTITION_TABLE_CUSTOM=y
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

CONFIG_ESP_TASK_WDT_INIT=n

CONFIG_VFS_MAX_COUNT=10
2 changes: 1 addition & 1 deletion examples/storage/nvs_rw_blob/pytest_nvs_rw_blob.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
# SPDX-License-Identifier: Unlicense OR CC0-1.0

import logging
import random
import re
Expand All @@ -13,6 +12,7 @@

@pytest.mark.esp32
@pytest.mark.esp32c3
@pytest.mark.generic
def test_examples_nvs_rw_blob(dut: Dut) -> None:
def expect_start_msg(index: int) -> None:
dut.expect('Restart counter = {}'.format(index), timeout=10)
Expand Down
6 changes: 4 additions & 2 deletions examples/storage/nvs_rw_value/pytest_nvs_rw_value.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
# SPDX-License-Identifier: Unlicense OR CC0-1.0

import logging
from itertools import zip_longest

Expand All @@ -10,11 +9,14 @@

@pytest.mark.esp32
@pytest.mark.esp32c3
@pytest.mark.generic
def test_examples_nvs_rw_value(dut: Dut) -> None:
dut.serial.erase_flash()
dut.serial.flash()
for i, counter_state in zip_longest(range(4), ('The value is not initialized yet!',), fillvalue='Done'):
dut.expect('Opening Non-Volatile Storage \\(NVS\\) handle... Done', timeout=20)
dut.expect('Reading restart counter from NVS ... {}'.format(counter_state), timeout=20)
dut.expect('Restart counter = {}'.format(i) if i > 0 else '', timeout=20)
dut.expect('Restart counter = {}'.format(i) if int(i) > 0 else '', timeout=20)
dut.expect('Updating restart counter in NVS ... Done', timeout=20)
dut.expect('Committing updates in NVS ... Done', timeout=20)
dut.expect('Restarting in 10 seconds...', timeout=20)
Expand Down
6 changes: 4 additions & 2 deletions examples/storage/nvs_rw_value_cxx/pytest_nvs_rw_value_cxx.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
# SPDX-License-Identifier: Unlicense OR CC0-1.0

import logging
from itertools import zip_longest

Expand All @@ -10,11 +9,14 @@

@pytest.mark.esp32
@pytest.mark.esp32c3
@pytest.mark.generic
def test_examples_nvs_rw_value_cxx(dut: Dut) -> None:
dut.serial.erase_flash()
dut.serial.flash()
for i, counter_state in zip_longest(range(4), ('The value is not initialized yet!',), fillvalue='Done'):
dut.expect('Opening Non-Volatile Storage \\(NVS\\) handle... Done', timeout=20)
dut.expect('Reading restart counter from NVS ... {}'.format(counter_state), timeout=20)
dut.expect('Restart counter = {}'.format(i) if i > 0 else '', timeout=20)
dut.expect('Restart counter = {}'.format(i) if int(i) > 0 else '', timeout=20)
dut.expect('Updating restart counter in NVS ... Done', timeout=20)
dut.expect('Committing updates in NVS ... Done', timeout=20)
dut.expect('Restarting in 10 seconds...', timeout=20)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ void app_main(void)
ESP_LOGI(TAG, "file still exists");
return;
} else {
ESP_LOGI(TAG, "file doesnt exist, format done");
ESP_LOGI(TAG, "file does not exist, format done");
}

//Create file and write
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
# SPDX-FileCopyrightText: 2022-2024 Espressif Systems (Shanghai) CO LTD
# SPDX-License-Identifier: Unlicense OR CC0-1.0


import re

import pytest
Expand All @@ -10,6 +8,7 @@

@pytest.mark.esp32
@pytest.mark.esp32c3
@pytest.mark.generic
def test_wear_levelling_example(dut: Dut) -> None:

message_list = ('example: Mounting FAT filesystem',
Expand All @@ -18,7 +17,7 @@ def test_wear_levelling_example(dut: Dut) -> None:
'example: Reading file',
re.compile(str.encode('example: Read from file: \'hello world, from ESP-IDF \\S+\'')),
re.compile(str.encode('vfs_fat_spiflash: Formatting FATFS partition, allocation unit size=\\S+')),
'example: file doesnt exist, format done',
'example: file does not exist, format done',
'example: Opening file',
'example: File written',
'example: Reading file',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@
# no_env_marker_test_cases: List of test cases that do not have environment markers.
# each item shall be the test node id, you may check the error message to get the node id.
no_env_marker_test_cases:
- components/nvs_flash/test_apps/pytest_nvs_flash.py::test_nvs_flash[default]
- components/vfs/test_apps/pytest_vfs.py::test_vfs_ccomp[ccomp]
- components/vfs/test_apps/pytest_vfs.py::test_vfs_default[default]
- components/vfs/test_apps/pytest_vfs.py::test_vfs_default[iram]
- examples/storage/nvs_rw_blob/pytest_nvs_rw_blob.py::test_examples_nvs_rw_blob
- examples/storage/nvs_rw_value/pytest_nvs_rw_value.py::test_examples_nvs_rw_value
- examples/storage/nvs_rw_value_cxx/pytest_nvs_rw_value_cxx.py::test_examples_nvs_rw_value_cxx
- examples/storage/wear_levelling/pytest_wear_levelling_example.py::test_wear_levelling_example
- dummy_test_case

# no_runner_tags: List of runner tags that has no test runner set.
# each item shall be a comma separated list of runner tags.
Expand Down

0 comments on commit 5b15320

Please sign in to comment.