-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for the ESP32-C6-DevKitC-1 #92
Conversation
I have also tested this using a local esphome-web-tools dev container, after building a esptool-js-0.2.1.tgz and placing it locally. |
@balloob - with the reverted line endings, is there anything outstanding on this PR? |
I'm sorry, I just hang around this repo as we rely on it downstream for ESP Web Tools. I am not able to review/merge PRs. |
Makes sense - the reason I am trying to get this merged is for eventual ESPHome support. If you don’t mind, to incorporate into a dev ESPHome:
is there a guide for a setting up a “fully local “ dev stack, to make integrating new chipsets easier for new starters? |
@brianignacio5 are you able to review this PR? |
Could you please check the lint errors ? Just run |
@brianignacio5 : local lint output (after 8ec78d5 and 23242c1): npm run lint
> [email protected] lint
> eslint . --ext .ts
/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32c3.ts
70:34 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
74:33 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32c6.ts
70:34 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
74:33 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32s2.ts
78:33 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32s3.ts
43:37 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
46:34 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
49:33 warning 'loader' is defined but never used @typescript-eslint/no-unused-vars
✖ 8 problems (0 errors, 8 warnings) Should be better now. |
LGTM ! |
This PR adds support for the ESP32-C6-DevKitC-1. It has been tested uploading the binary outputs from esp-idf